ALSA: hda/tas2781: Fix error code tas2781_read_acpi()

Dan Carpenter · tiwai · commit a0cd2b265fe3 · 2024-12-01T09:51:33.000+01:00
Return an error code if acpi_get_subsystem_id() fails. Don't return success. Fixes: 4e7035a ("ALSA: hda/tas2781: Add speaker id check for ASUS projects") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://patch.msgid.link/ef773f8a-a61d-478b-9e81-41a38a75c77b@stanley.mountain Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
@@ -143,6 +143,7 @@ static int tas2781_read_acpi(struct tasdevice_priv *p, const char *hid)
 	sub = acpi_get_subsystem_id(ACPI_HANDLE(physdev));
 	if (IS_ERR(sub)) {
 		dev_err(p->dev, "Failed to get SUBSYS ID.\n");
+		ret = PTR_ERR(sub);
 		goto err;
 	}
 	/* Speaker id was needed for ASUS projects. */

Original file line number	Diff line number	Diff line change
`@@ -143,6 +143,7 @@ static int tas2781_read_acpi(struct tasdevice_priv p, const char hid)`
`143`	`143`	`sub = acpi_get_subsystem_id(ACPI_HANDLE(physdev));`
`144`	`144`	`if (IS_ERR(sub)) {`
`145`	`145`	`dev_err(p->dev, "Failed to get SUBSYS ID.\n");`
	`146`	`+ ret = PTR_ERR(sub);`
`146`	`147`	`goto err;`
`147`	`148`	`}`
`148`	`149`	`/* Speaker id was needed for ASUS projects. */`