mctp: return -ENOPROTOOPT for unknown getsockopt options

aloktiwa · kuba-moo · commit a125c8fb9ddb · 2025-09-03T17:01:52.000-07:00
In mctp_getsockopt(), unrecognized options currently return -EINVAL. In contrast, mctp_setsockopt() returns -ENOPROTOOPT for unknown options. Update mctp_getsockopt() to also return -ENOPROTOOPT for unknown options. This aligns the behavior of getsockopt() and setsockopt(), and matches the standard kernel socket API convention for handling unsupported options. Fixes: 99ce45d ("mctp: Implement extended addressing") Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> Link: https://patch.msgid.link/20250902102059.1370008-1-alok.a.tiwari@oracle.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/net/mctp/af_mctp.c b/net/mctp/af_mctp.c
@@ -425,7 +425,7 @@ static int mctp_getsockopt(struct socket *sock, int level, int optname,
 		return 0;
 	}
 
-	return -EINVAL;
+	return -ENOPROTOOPT;
 }
 
 /* helpers for reading/writing the tag ioc, handling compatibility across the

Original file line number	Diff line number	Diff line change
`@@ -425,7 +425,7 @@ static int mctp_getsockopt(struct socket *sock, int level, int optname,`
`425`	`425`	`return 0;`
`426`	`426`	`}`
`427`	`427`
`428`		`- return -EINVAL;`
	`428`	`+ return -ENOPROTOOPT;`
`429`	`429`	`}`
`430`	`430`
`431`	`431`	`/* helpers for reading/writing the tag ioc, handling compatibility across the`