Skip to content

Commit a158281

Browse files
Darksonnjannau
authored andcommitted
panthor: use drm_gem_object.gpuva.lock instead of gpuva_list_lock
Now that drm_gem_object has a dedicated mutex for the gpuva list that is intended to be used in cases that must be fence signalling safe, use it in Panthor. Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Signed-off-by: Alice Ryhl <aliceryhl@google.com> Link: https://lore.kernel.org/r/20250827-gpuva-mutex-in-gem-v3-2-bd89f5a82c0d@google.com Signed-off-by: Danilo Krummrich <dakr@kernel.org>
1 parent f89ab12 commit a158281

3 files changed

Lines changed: 9 additions & 23 deletions

File tree

drivers/gpu/drm/panthor/panthor_gem.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ static void panthor_gem_free_object(struct drm_gem_object *obj)
7474
mutex_destroy(&bo->label.lock);
7575

7676
drm_gem_free_mmap_offset(&bo->base.base);
77-
mutex_destroy(&bo->gpuva_list_lock);
7877
drm_gem_shmem_free(&bo->base);
7978
drm_gem_object_put(vm_root_gem);
8079
}
@@ -246,8 +245,7 @@ struct drm_gem_object *panthor_gem_create_object(struct drm_device *ddev, size_t
246245

247246
obj->base.base.funcs = &panthor_gem_funcs;
248247
obj->base.map_wc = !ptdev->coherent;
249-
mutex_init(&obj->gpuva_list_lock);
250-
drm_gem_gpuva_set_lock(&obj->base.base, &obj->gpuva_list_lock);
248+
drm_gem_gpuva_set_lock(&obj->base.base, &obj->base.base.gpuva.lock);
251249
mutex_init(&obj->label.lock);
252250

253251
panthor_gem_debugfs_bo_init(obj);

drivers/gpu/drm/panthor/panthor_gem.h

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -79,18 +79,6 @@ struct panthor_gem_object {
7979
*/
8080
struct drm_gem_object *exclusive_vm_root_gem;
8181

82-
/**
83-
* @gpuva_list_lock: Custom GPUVA lock.
84-
*
85-
* Used to protect insertion of drm_gpuva elements to the
86-
* drm_gem_object.gpuva.list list.
87-
*
88-
* We can't use the GEM resv for that, because drm_gpuva_link() is
89-
* called in a dma-signaling path, where we're not allowed to take
90-
* resv locks.
91-
*/
92-
struct mutex gpuva_list_lock;
93-
9482
/** @flags: Combination of drm_panthor_bo_flags flags. */
9583
u32 flags;
9684

drivers/gpu/drm/panthor/panthor_mmu.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1074,9 +1074,9 @@ static void panthor_vm_bo_put(struct drm_gpuvm_bo *vm_bo)
10741074
* GEM vm_bo list.
10751075
*/
10761076
dma_resv_lock(drm_gpuvm_resv(vm), NULL);
1077-
mutex_lock(&bo->gpuva_list_lock);
1077+
mutex_lock(&bo->base.base.gpuva.lock);
10781078
unpin = drm_gpuvm_bo_put(vm_bo);
1079-
mutex_unlock(&bo->gpuva_list_lock);
1079+
mutex_unlock(&bo->base.base.gpuva.lock);
10801080
dma_resv_unlock(drm_gpuvm_resv(vm));
10811081

10821082
/* If the vm_bo object was destroyed, release the pin reference that
@@ -1253,9 +1253,9 @@ static int panthor_vm_prepare_map_op_ctx(struct panthor_vm_op_ctx *op_ctx,
12531253
* calling this function.
12541254
*/
12551255
dma_resv_lock(panthor_vm_resv(vm), NULL);
1256-
mutex_lock(&bo->gpuva_list_lock);
1256+
mutex_lock(&bo->base.base.gpuva.lock);
12571257
op_ctx->map.vm_bo = drm_gpuvm_bo_obtain_prealloc(preallocated_vm_bo);
1258-
mutex_unlock(&bo->gpuva_list_lock);
1258+
mutex_unlock(&bo->base.base.gpuva.lock);
12591259
dma_resv_unlock(panthor_vm_resv(vm));
12601260

12611261
/* If the a vm_bo for this <VM,BO> combination exists, it already
@@ -2007,10 +2007,10 @@ static void panthor_vma_link(struct panthor_vm *vm,
20072007
{
20082008
struct panthor_gem_object *bo = to_panthor_bo(vma->base.gem.obj);
20092009

2010-
mutex_lock(&bo->gpuva_list_lock);
2010+
mutex_lock(&bo->base.base.gpuva.lock);
20112011
drm_gpuva_link(&vma->base, vm_bo);
20122012
drm_WARN_ON(&vm->ptdev->base, drm_gpuvm_bo_put(vm_bo));
2013-
mutex_unlock(&bo->gpuva_list_lock);
2013+
mutex_unlock(&bo->base.base.gpuva.lock);
20142014
}
20152015

20162016
static void panthor_vma_unlink(struct panthor_vm *vm,
@@ -2019,9 +2019,9 @@ static void panthor_vma_unlink(struct panthor_vm *vm,
20192019
struct panthor_gem_object *bo = to_panthor_bo(vma->base.gem.obj);
20202020
struct drm_gpuvm_bo *vm_bo = drm_gpuvm_bo_get(vma->base.vm_bo);
20212021

2022-
mutex_lock(&bo->gpuva_list_lock);
2022+
mutex_lock(&bo->base.base.gpuva.lock);
20232023
drm_gpuva_unlink(&vma->base);
2024-
mutex_unlock(&bo->gpuva_list_lock);
2024+
mutex_unlock(&bo->base.base.gpuva.lock);
20252025

20262026
/* drm_gpuva_unlink() release the vm_bo, but we manually retained it
20272027
* when entering this function, so we can implement deferred VMA

0 commit comments

Comments
 (0)