Skip to content

Commit a318eb8

Browse files
aloktiwamstsirkin
authored andcommitted
vhost-scsi: fix argument order in tport allocation error message
The error log in vhost_scsi_make_tport() prints the arguments in the wrong order, producing confusing output. For example, when creating a target with a name in WWNN format such as "fc.port1234", the log looks like: Emulated fc.port1234 Address: FCP, exceeds max: 64 Instead, the message should report the emulated protocol type first, followed by the configfs name as: Emulated FCP Address: fc.port1234, exceeds max: 64 Fix the argument order so the error log is consistent and clear. Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> Message-Id: <20250913154106.3995856-1-alok.a.tiwari@oracle.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
1 parent 76eeb9b commit a318eb8

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/vhost/scsi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2884,7 +2884,7 @@ vhost_scsi_make_tport(struct target_fabric_configfs *tf,
28842884
check_len:
28852885
if (strlen(name) >= VHOST_SCSI_NAMELEN) {
28862886
pr_err("Emulated %s Address: %s, exceeds"
2887-
" max: %d\n", name, vhost_scsi_dump_proto_id(tport),
2887+
" max: %d\n", vhost_scsi_dump_proto_id(tport), name,
28882888
VHOST_SCSI_NAMELEN);
28892889
kfree(tport);
28902890
return ERR_PTR(-EINVAL);

0 commit comments

Comments
 (0)