Skip to content

Commit a34606a

Browse files
committed
rnbd: port block device access to file
Link: https://lore.kernel.org/r/20240123-vfs-bdev-file-v2-10-adbd023e19cc@kernel.org Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 05fb1db commit a34606a

2 files changed

Lines changed: 15 additions & 15 deletions

File tree

drivers/block/rnbd/rnbd-srv.c

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ static int process_rdma(struct rnbd_srv_session *srv_sess,
145145
priv->sess_dev = sess_dev;
146146
priv->id = id;
147147

148-
bio = bio_alloc(sess_dev->bdev_handle->bdev, 1,
148+
bio = bio_alloc(file_bdev(sess_dev->bdev_file), 1,
149149
rnbd_to_bio_flags(le32_to_cpu(msg->rw)), GFP_KERNEL);
150150
if (bio_add_page(bio, virt_to_page(data), datalen,
151151
offset_in_page(data)) != datalen) {
@@ -219,7 +219,7 @@ void rnbd_destroy_sess_dev(struct rnbd_srv_sess_dev *sess_dev, bool keep_id)
219219
rnbd_put_sess_dev(sess_dev);
220220
wait_for_completion(&dc); /* wait for inflights to drop to zero */
221221

222-
bdev_release(sess_dev->bdev_handle);
222+
fput(sess_dev->bdev_file);
223223
mutex_lock(&sess_dev->dev->lock);
224224
list_del(&sess_dev->dev_list);
225225
if (!sess_dev->readonly)
@@ -534,7 +534,7 @@ rnbd_srv_get_or_create_srv_dev(struct block_device *bdev,
534534
static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
535535
struct rnbd_srv_sess_dev *sess_dev)
536536
{
537-
struct block_device *bdev = sess_dev->bdev_handle->bdev;
537+
struct block_device *bdev = file_bdev(sess_dev->bdev_file);
538538

539539
rsp->hdr.type = cpu_to_le16(RNBD_MSG_OPEN_RSP);
540540
rsp->device_id = cpu_to_le32(sess_dev->device_id);
@@ -560,7 +560,7 @@ static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
560560
static struct rnbd_srv_sess_dev *
561561
rnbd_srv_create_set_sess_dev(struct rnbd_srv_session *srv_sess,
562562
const struct rnbd_msg_open *open_msg,
563-
struct bdev_handle *handle, bool readonly,
563+
struct file *bdev_file, bool readonly,
564564
struct rnbd_srv_dev *srv_dev)
565565
{
566566
struct rnbd_srv_sess_dev *sdev = rnbd_sess_dev_alloc(srv_sess);
@@ -572,7 +572,7 @@ rnbd_srv_create_set_sess_dev(struct rnbd_srv_session *srv_sess,
572572

573573
strscpy(sdev->pathname, open_msg->dev_name, sizeof(sdev->pathname));
574574

575-
sdev->bdev_handle = handle;
575+
sdev->bdev_file = bdev_file;
576576
sdev->sess = srv_sess;
577577
sdev->dev = srv_dev;
578578
sdev->readonly = readonly;
@@ -678,7 +678,7 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess,
678678
struct rnbd_srv_dev *srv_dev;
679679
struct rnbd_srv_sess_dev *srv_sess_dev;
680680
const struct rnbd_msg_open *open_msg = msg;
681-
struct bdev_handle *bdev_handle;
681+
struct file *bdev_file;
682682
blk_mode_t open_flags = BLK_OPEN_READ;
683683
char *full_path;
684684
struct rnbd_msg_open_rsp *rsp = data;
@@ -716,15 +716,15 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess,
716716
goto reject;
717717
}
718718

719-
bdev_handle = bdev_open_by_path(full_path, open_flags, NULL, NULL);
720-
if (IS_ERR(bdev_handle)) {
721-
ret = PTR_ERR(bdev_handle);
719+
bdev_file = bdev_file_open_by_path(full_path, open_flags, NULL, NULL);
720+
if (IS_ERR(bdev_file)) {
721+
ret = PTR_ERR(bdev_file);
722722
pr_err("Opening device '%s' on session %s failed, failed to open the block device, err: %pe\n",
723-
full_path, srv_sess->sessname, bdev_handle);
723+
full_path, srv_sess->sessname, bdev_file);
724724
goto free_path;
725725
}
726726

727-
srv_dev = rnbd_srv_get_or_create_srv_dev(bdev_handle->bdev, srv_sess,
727+
srv_dev = rnbd_srv_get_or_create_srv_dev(file_bdev(bdev_file), srv_sess,
728728
open_msg->access_mode);
729729
if (IS_ERR(srv_dev)) {
730730
pr_err("Opening device '%s' on session %s failed, creating srv_dev failed, err: %pe\n",
@@ -734,7 +734,7 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess,
734734
}
735735

736736
srv_sess_dev = rnbd_srv_create_set_sess_dev(srv_sess, open_msg,
737-
bdev_handle,
737+
bdev_file,
738738
open_msg->access_mode == RNBD_ACCESS_RO,
739739
srv_dev);
740740
if (IS_ERR(srv_sess_dev)) {
@@ -750,7 +750,7 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess,
750750
*/
751751
mutex_lock(&srv_dev->lock);
752752
if (!srv_dev->dev_kobj.state_in_sysfs) {
753-
ret = rnbd_srv_create_dev_sysfs(srv_dev, bdev_handle->bdev);
753+
ret = rnbd_srv_create_dev_sysfs(srv_dev, file_bdev(bdev_file));
754754
if (ret) {
755755
mutex_unlock(&srv_dev->lock);
756756
rnbd_srv_err(srv_sess_dev,
@@ -793,7 +793,7 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess,
793793
}
794794
rnbd_put_srv_dev(srv_dev);
795795
blkdev_put:
796-
bdev_release(bdev_handle);
796+
fput(bdev_file);
797797
free_path:
798798
kfree(full_path);
799799
reject:

drivers/block/rnbd/rnbd-srv.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ struct rnbd_srv_dev {
4646
struct rnbd_srv_sess_dev {
4747
/* Entry inside rnbd_srv_dev struct */
4848
struct list_head dev_list;
49-
struct bdev_handle *bdev_handle;
49+
struct file *bdev_file;
5050
struct rnbd_srv_session *sess;
5151
struct rnbd_srv_dev *dev;
5252
struct kobject kobj;

0 commit comments

Comments
 (0)