Skip to content

Commit a3a2237

Browse files
lumagRob Clark
authored andcommitted
drm/msm/a2xx: stop over-complaining about the legacy firmware
If the rootfs have a legacy A200 firmware, currently the driver will complain each time the hw is reinited (which can happen a lot). E.g. with GL testsuite the hw is reinited after each test, spamming the console. Make sure that the message is printed only once: when we detect the firmware that doesn't support protection. Fixes: 3022950 ("drm/msm/a2xx: support loading legacy (iMX) firmware") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Patchwork: https://patchwork.freedesktop.org/patch/688098/ Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
1 parent 3065e6a commit a3a2237

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/msm/adreno/a2xx_gpu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ static int a2xx_hw_init(struct msm_gpu *gpu)
234234
* word (0x20xxxx for A200, 0x220xxx for A220, 0x225xxx for A225).
235235
* Older firmware files, which lack protection support, have 0 instead.
236236
*/
237-
if (ptr[1] == 0) {
237+
if (ptr[1] == 0 && !a2xx_gpu->protection_disabled) {
238238
dev_warn(gpu->dev->dev,
239239
"Legacy firmware detected, disabling protection support\n");
240240
a2xx_gpu->protection_disabled = true;

0 commit comments

Comments
 (0)