Skip to content

Commit a3c4445

Browse files
ChenXiaoSongsmfrench
authored andcommitted
smb/server: fix return value of smb2_oplock_break()
smb2_oplock_break() should return error code when an error occurs, __process_request() will print the error messages. Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 269df04 commit a3c4445

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

fs/smb/server/smb2pdu.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8748,7 +8748,7 @@ static void smb21_lease_break_ack(struct ksmbd_work *work)
87488748
* smb2_oplock_break() - dispatcher for smb2.0 and 2.1 oplock/lease break
87498749
* @work: smb work containing oplock/lease break command buffer
87508750
*
8751-
* Return: 0
8751+
* Return: 0 on success, otherwise error
87528752
*/
87538753
int smb2_oplock_break(struct ksmbd_work *work)
87548754
{
@@ -8771,6 +8771,7 @@ int smb2_oplock_break(struct ksmbd_work *work)
87718771
le16_to_cpu(req->StructureSize));
87728772
rsp->hdr.Status = STATUS_INVALID_PARAMETER;
87738773
smb2_set_err_rsp(work);
8774+
return -EINVAL;
87748775
}
87758776

87768777
return 0;

0 commit comments

Comments
 (0)