Skip to content

Commit a519bc0

Browse files
nxpfrankligregkh
authored andcommitted
arm64: dts: imx8mn-tqma8mqnl-mba8mx-usbot: fix coexistence of output-low and output-high in GPIO
[ Upstream commit c771d31 ] Fix the issue where both 'output-low' and 'output-high' exist under GPIO hog nodes (rst_usb_hub_hog and sel_usb_hub_hog) when applying device tree overlays. Since /delete-property/ is not supported in the overlays, setting 'output-low' results in both properties being present. The workaround is to disable these hogs and create new ones with 'output-low' as needed. Fix below CHECK_DTBS warning: arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx-usbotg.dtb: sel-usb-hub-hog: {'output-low': True, 'gpio-hog': True, 'gpios': [[1, 0]], 'output-high': True, 'phandle': 108, '$nodename': ['sel-usb-hub-hog']} is valid under each of {'required': ['output-low']}, {'required': ['output-high'] Fixes: 3f6fc30 ("arm64: dts: imx8mn: tqma8mqnl-mba8mx: Add USB DR overlay") Signed-off-by: Frank Li <Frank.Li@nxp.com> Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 738dbef commit a519bc0

1 file changed

Lines changed: 27 additions & 2 deletions

File tree

arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx-usbotg.dtso

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,37 @@
2929
};
3030
};
3131

32+
/*
33+
* rst_usb_hub_hog and sel_usb_hub_hog have property 'output-high',
34+
* dt overlay don't support /delete-property/. Both 'output-low' and
35+
* 'output-high' will be exist under hog nodes if overlay file set
36+
* 'output-low'. Workaround is disable these hog and create new hog with
37+
* 'output-low'.
38+
*/
39+
3240
&rst_usb_hub_hog {
33-
output-low;
41+
status = "disabled";
42+
};
43+
44+
&expander0 {
45+
rst-usb-low-hub-hog {
46+
gpio-hog;
47+
gpios = <13 0>;
48+
output-low;
49+
line-name = "RST_USB_HUB#";
50+
};
3451
};
3552

3653
&sel_usb_hub_hog {
37-
output-low;
54+
status = "disabled";
55+
};
56+
57+
&gpio2 {
58+
sel-usb-low-hub-hog {
59+
gpio-hog;
60+
gpios = <1 GPIO_ACTIVE_HIGH>;
61+
output-low;
62+
};
3863
};
3964

4065
&usbotg1 {

0 commit comments

Comments
 (0)