Skip to content

Commit a5be4ab

Browse files
marcanjannau
authored andcommitted
usb: typec: tipd: Be more verbose about errors
Make sure to print out error codes and log exactly what packet sizes were received in case of a mismatch. This is very useful for debugging badness. Signed-off-by: Hector Martin <marcan@marcan.st>
1 parent 0b225a4 commit a5be4ab

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

drivers/usb/typec/tipd/core.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,11 +171,15 @@ tps6598x_block_read(struct tps6598x *tps, u8 reg, void *val, size_t len)
171171
return regmap_raw_read(tps->regmap, reg, val, len);
172172

173173
ret = regmap_raw_read(tps->regmap, reg, data, len + 1);
174-
if (ret)
174+
if (ret) {
175+
dev_err(tps->dev, "regmap_raw_read returned %d\n", ret);
175176
return ret;
177+
}
176178

177-
if (data[0] < len)
179+
if (data[0] < len) {
180+
dev_err(tps->dev, "expected %zu bytes, got %d\n", len, data[0]);
178181
return -EIO;
182+
}
179183

180184
memcpy(val, &data[1], len);
181185
return 0;
@@ -470,7 +474,7 @@ static bool tps6598x_read_status(struct tps6598x *tps, u32 *status)
470474

471475
ret = tps6598x_read32(tps, TPS_REG_STATUS, status);
472476
if (ret) {
473-
dev_err(tps->dev, "%s: failed to read status\n", __func__);
477+
dev_err(tps->dev, "%s: failed to read status: %d\n", __func__, ret);
474478
return false;
475479
}
476480

0 commit comments

Comments
 (0)