Skip to content

Commit a6e8478

Browse files
mmindgregkh
authored andcommitted
arm64: dts: rockchip: Remove 'enable-active-low' from two boards
[ Upstream commit 4a9d7e6 ] The 'enable-active-low' property is not a valid, because it is the default behaviour of the fixed regulator. Only 'enable-active-high' is valid, and when this property is absent the fixed regulator will act as active low by default. Both the rk3588-orange-pi-5 and the Wolfvision pf5 io expander overlay smuggled those enable-active-low properties in, so remove them to make dtbscheck happier. Fixes: 28799a7 ("arm64: dts: rockchip: add wolfvision pf5 io expander board") Cc: Michael Riesch <michael.riesch@wolfvision.net> Fixes: b6bc755 ("arm64: dts: rockchip: Add Orange Pi 5") Cc: Muhammed Efe Cetin <efectn@6tel.net> Reviewed-by: Michael Riesch <michael.riesch@wolfvision.net> Reviewed-by: Dragan Simic <dsimic@manjaro.org> Signed-off-by: Heiko Stuebner <heiko@sntech.de> Link: https://lore.kernel.org/r/20241008203940.2573684-10-heiko@sntech.de Signed-off-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 156d76a commit a6e8478

2 files changed

Lines changed: 0 additions & 2 deletions

File tree

arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949

5050
vcc3v3_eth: vcc3v3-eth-regulator {
5151
compatible = "regulator-fixed";
52-
enable-active-low;
5352
gpio = <&gpio0 RK_PC0 GPIO_ACTIVE_LOW>;
5453
pinctrl-names = "default";
5554
pinctrl-0 = <&vcc3v3_eth_enn>;

arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@
7171

7272
vcc_3v3_sd_s0: vcc-3v3-sd-s0-regulator {
7373
compatible = "regulator-fixed";
74-
enable-active-low;
7574
gpios = <&gpio4 RK_PB5 GPIO_ACTIVE_LOW>;
7675
regulator-name = "vcc_3v3_sd_s0";
7776
regulator-boot-on;

0 commit comments

Comments
 (0)