Skip to content

Commit a6f494b

Browse files
Akshay Jindalbjorn-helgaas
authored andcommitted
PCI/AER: Add message when AER_MAX_MULTI_ERR_DEVICES limit is hit
When a PCIe device detects an error, it logs the error locally and issues an error Message routed to the Root Complex (PCIe r6.0, sec 6.2.5). If the Root Port or RCEC supports AER and Linux has enabled the AER interrupt, aer_isr() traverses the relevant devices and adds those with AER errors logged to the aer_err_info.dev[] array for error logging and recovery. If aer_isr() finds more than AER_MAX_MULTI_ERR_DEVICES devices with AER errors logged, it silently ignores them, and those extra devices are not included in the recovery flow. Emit an error message if we find more than AER_MAX_MULTI_ERR_DEVICES devices with AER errors logged. Testing details at link below. Signed-off-by: Akshay Jindal <akshayaj.lkd@gmail.com> [bhelgaas: commit log, join error message] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Link: https://patch.msgid.link/20250619185041.73240-1-akshayaj.lkd@gmail.com
1 parent 9890dd3 commit a6f494b

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/pci/pcie/aer.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1039,7 +1039,8 @@ static int find_device_iter(struct pci_dev *dev, void *data)
10391039
/* List this device */
10401040
if (add_error_device(e_info, dev)) {
10411041
/* We cannot handle more... Stop iteration */
1042-
/* TODO: Should print error message here? */
1042+
pci_err(dev, "Exceeded max supported (%d) devices with errors logged\n",
1043+
AER_MAX_MULTI_ERR_DEVICES);
10431044
return 1;
10441045
}
10451046

0 commit comments

Comments
 (0)