Skip to content

Commit a80c98b

Browse files
Troy Hansonquic-jhugo
authored andcommitted
accel/qaic: Rename constant for clarity
QAIC_MANAGE_EXT_MSG_LENGTH is ambiguous and has been confused with QAIC_MANAGE_MAX_MSG_LENGTH. Rename it to clarify it's a wire length. Signed-off-by: Troy Hanson <thanson@qti.qualcomm.com> Signed-off-by: Youssef Samir <youssef.abdulrahman@oss.qualcomm.com> Reviewed-by: Carl Vanderlip <carl.vanderlip@oss.qualcomm.com> Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com> [jhugo: capitalize subject] Signed-off-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com> Link: https://patch.msgid.link/20251022141606.3740470-1-youssef.abdulrahman@oss.qualcomm.com
1 parent b3ba217 commit a80c98b

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

drivers/accel/qaic/qaic_control.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
#define MANAGE_MAGIC_NUMBER ((__force __le32)0x43494151) /* "QAIC" in little endian */
3232
#define QAIC_DBC_Q_GAP SZ_256
3333
#define QAIC_DBC_Q_BUF_ALIGN SZ_4K
34-
#define QAIC_MANAGE_EXT_MSG_LENGTH SZ_64K /* Max DMA message length */
34+
#define QAIC_MANAGE_WIRE_MSG_LENGTH SZ_64K /* Max DMA message length */
3535
#define QAIC_WRAPPER_MAX_SIZE SZ_4K
3636
#define QAIC_MHI_RETRY_WAIT_MS 100
3737
#define QAIC_MHI_RETRY_MAX 20
@@ -368,7 +368,7 @@ static int encode_passthrough(struct qaic_device *qdev, void *trans, struct wrap
368368
if (in_trans->hdr.len % 8 != 0)
369369
return -EINVAL;
370370

371-
if (size_add(msg_hdr_len, in_trans->hdr.len) > QAIC_MANAGE_EXT_MSG_LENGTH)
371+
if (size_add(msg_hdr_len, in_trans->hdr.len) > QAIC_MANAGE_WIRE_MSG_LENGTH)
372372
return -ENOSPC;
373373

374374
trans_wrapper = add_wrapper(wrappers,
@@ -496,7 +496,7 @@ static int encode_addr_size_pairs(struct dma_xfer *xfer, struct wrapper_list *wr
496496

497497
nents = sgt->nents;
498498
nents_dma = nents;
499-
*size = QAIC_MANAGE_EXT_MSG_LENGTH - msg_hdr_len - sizeof(**out_trans);
499+
*size = QAIC_MANAGE_WIRE_MSG_LENGTH - msg_hdr_len - sizeof(**out_trans);
500500
for_each_sgtable_dma_sg(sgt, sg, i) {
501501
*size -= sizeof(*asp);
502502
/* Save 1K for possible follow-up transactions. */
@@ -577,7 +577,7 @@ static int encode_dma(struct qaic_device *qdev, void *trans, struct wrapper_list
577577

578578
/* There should be enough space to hold at least one ASP entry. */
579579
if (size_add(msg_hdr_len, sizeof(*out_trans) + sizeof(struct wire_addr_size_pair)) >
580-
QAIC_MANAGE_EXT_MSG_LENGTH)
580+
QAIC_MANAGE_WIRE_MSG_LENGTH)
581581
return -ENOMEM;
582582

583583
xfer = kmalloc(sizeof(*xfer), GFP_KERNEL);
@@ -646,7 +646,7 @@ static int encode_activate(struct qaic_device *qdev, void *trans, struct wrapper
646646
msg = &wrapper->msg;
647647
msg_hdr_len = le32_to_cpu(msg->hdr.len);
648648

649-
if (size_add(msg_hdr_len, sizeof(*out_trans)) > QAIC_MANAGE_MAX_MSG_LENGTH)
649+
if (size_add(msg_hdr_len, sizeof(*out_trans)) > QAIC_MANAGE_WIRE_MSG_LENGTH)
650650
return -ENOSPC;
651651

652652
if (!in_trans->queue_size)
@@ -731,7 +731,7 @@ static int encode_status(struct qaic_device *qdev, void *trans, struct wrapper_l
731731
msg = &wrapper->msg;
732732
msg_hdr_len = le32_to_cpu(msg->hdr.len);
733733

734-
if (size_add(msg_hdr_len, in_trans->hdr.len) > QAIC_MANAGE_MAX_MSG_LENGTH)
734+
if (size_add(msg_hdr_len, in_trans->hdr.len) > QAIC_MANAGE_WIRE_MSG_LENGTH)
735735
return -ENOSPC;
736736

737737
trans_wrapper = add_wrapper(wrappers, sizeof(*trans_wrapper));
@@ -1054,7 +1054,7 @@ static void *msg_xfer(struct qaic_device *qdev, struct wrapper_list *wrappers, u
10541054
init_completion(&elem.xfer_done);
10551055
if (likely(!qdev->cntl_lost_buf)) {
10561056
/*
1057-
* The max size of request to device is QAIC_MANAGE_EXT_MSG_LENGTH.
1057+
* The max size of request to device is QAIC_MANAGE_WIRE_MSG_LENGTH.
10581058
* The max size of response from device is QAIC_MANAGE_MAX_MSG_LENGTH.
10591059
*/
10601060
out_buf = kmalloc(QAIC_MANAGE_MAX_MSG_LENGTH, GFP_KERNEL);

0 commit comments

Comments
 (0)