Skip to content

Commit a846505

Browse files
YuuoniyChun-Kuang Hu
authored andcommitted
drm/mediatek: Fix device node reference leak in mtk_dp_dt_parse()
The function mtk_dp_dt_parse() calls of_graph_get_endpoint_by_regs() to get the endpoint device node, but fails to call of_node_put() to release the reference when the function returns. This results in a device node reference leak. Fix this by adding the missing of_node_put() call before returning from the function. Found via static analysis and code review. Fixes: f70ac09 ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com> Reviewed-by: CK Hu <ck.hu@mediatek.com> Link: https://patchwork.kernel.org/project/dri-devel/patch/20251029072307.10955-1-linmq006@gmail.com/ Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
1 parent 20ac36b commit a846505

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/gpu/drm/mediatek/mtk_dp.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2087,6 +2087,7 @@ static int mtk_dp_dt_parse(struct mtk_dp *mtk_dp,
20872087
endpoint = of_graph_get_endpoint_by_regs(pdev->dev.of_node, 1, -1);
20882088
len = of_property_count_elems_of_size(endpoint,
20892089
"data-lanes", sizeof(u32));
2090+
of_node_put(endpoint);
20902091
if (len < 0 || len > 4 || len == 3) {
20912092
dev_err(dev, "invalid data lane size: %d\n", len);
20922093
return -EINVAL;

0 commit comments

Comments
 (0)