Skip to content

Commit a98e0d6

Browse files
author
Eric Biggers
committed
nvmem: layouts: Switch from crc32() to crc32_le()
u_boot_env_parse() calls crc32() from within a scope that has a uint32_t variable named crc32. This works only because crc32() is actually a macro that expands to crc32_le(). I'm planning to make it an inline function instead, which will make the usual C scoping rules apply to it. Therefore, update u_boot_env_parse() to be compatible with that. To do so, just call crc32_le() directly instead of using the crc32() alias. (An alternative would be to rename the local variable.) Acked-by: Srinivas Kandagatla <srini@kernel.org> Link: https://lore.kernel.org/r/20250620205027.23403-1-ebiggers@kernel.org Signed-off-by: Eric Biggers <ebiggers@kernel.org>
1 parent 8c7c675 commit a98e0d6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/nvmem/layouts/u-boot-env.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ int u_boot_env_parse(struct device *dev, struct nvmem_device *nvmem,
148148
crc32_data_len = dev_size - crc32_data_offset;
149149
data_len = dev_size - data_offset;
150150

151-
calc = crc32(~0, buf + crc32_data_offset, crc32_data_len) ^ ~0L;
151+
calc = crc32_le(~0, buf + crc32_data_offset, crc32_data_len) ^ ~0L;
152152
if (calc != crc32) {
153153
dev_err(dev, "Invalid calculated CRC32: 0x%08x (expected: 0x%08x)\n", calc, crc32);
154154
err = -EINVAL;

0 commit comments

Comments
 (0)