Skip to content

Commit a9ce09b

Browse files
Dan Carpenterakpm00
authored andcommitted
mm/damon/tests/sysfs-kunit: fix use after free on error path
Re-order these frees to avoid dereferencing "sysfs_target" after it has been freed. Link: https://lkml.kernel.org/r/aSBq5uSPIqsqH8zO@stanley.mountain Fixes: ee13169 ("mm/damon/tests/sysfs-kunit: handle alloc failures on damon_sysfs_test_add_targets()") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: SeongJae Park <sj@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 348ced3 commit a9ce09b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

mm/damon/tests/sysfs-kunit.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ static void damon_sysfs_test_add_targets(struct kunit *test)
7676
if (!ctx) {
7777
kfree(sysfs_targets->targets_arr);
7878
kfree(sysfs_targets);
79-
kfree(sysfs_target);
8079
kfree(sysfs_target->regions);
80+
kfree(sysfs_target);
8181
kunit_skip(test, "ctx alloc fail");
8282
}
8383

0 commit comments

Comments
 (0)