Skip to content

Commit aabf4ff

Browse files
Dan CarpenterKAGA-KOKO
authored andcommitted
irqchip/ls-scfg-msi: Fix NULL dereference in error handling
The call to irq_domain_remove(msi_data->parent); was accidentally left behind during a code refactor. It's not necessary to free "msi_data->parent" because it is NULL and, in fact, trying to free it will lead to a NULL pointer dereference. Delete the unnecessary code. Fixes: 94b59d5 ("irqchip/ls-scfg-msi: Switch to use msi_create_parent_irq_domain()") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Nam Cao <namcao@linutronix.de> Link: https://lore.kernel.org/all/15059507-6422-4333-94ca-e8e8840bd289@sabinyo.mountain
1 parent 94b59d5 commit aabf4ff

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/irqchip/irq-ls-scfg-msi.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,6 @@ static int ls_scfg_msi_domains_init(struct ls_scfg_msi *msi_data)
226226
msi_data->parent = msi_create_parent_irq_domain(&info, &ls_scfg_msi_parent_ops);
227227
if (!msi_data->parent) {
228228
dev_err(&msi_data->pdev->dev, "failed to create MSI domain\n");
229-
irq_domain_remove(msi_data->parent);
230229
return -ENOMEM;
231230
}
232231

0 commit comments

Comments
 (0)