Skip to content

Commit aac95b3

Browse files
Jiawen Wugregkh
authored andcommitted
net: txgbe: remove the redundant data return in SW-FW mailbox
commit 3d778e6 upstream. For these two firmware mailbox commands, in txgbe_test_hostif() and txgbe_set_phy_link_hostif(), there is no need to read data from the buffer. Under the current setting, OEM firmware will cause the driver to fail to probe. Because OEM firmware returns more link information, with a larger OEM structure txgbe_hic_ephy_getlink. However, the current driver does not support the OEM function. So just fix it in the way that does not involve reading the returned data. Fixes: d84a3ff ("net: txgbe: Restrict the use of mismatched FW versions") Cc: stable@vger.kernel.org Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com> Link: https://patch.msgid.link/2914AB0BC6158DDA+20260119065935.6015-1-jiawenwu@trustnetic.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 69b5b02 commit aac95b3

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ int txgbe_test_hostif(struct wx *wx)
6565
buffer.hdr.cmd_or_resp.cmd_resv = FW_CEM_CMD_RESERVED;
6666

6767
return wx_host_interface_command(wx, (u32 *)&buffer, sizeof(buffer),
68-
WX_HI_COMMAND_TIMEOUT, true);
68+
WX_HI_COMMAND_TIMEOUT, false);
6969
}
7070

7171
static int txgbe_identify_sfp_hostif(struct wx *wx, struct txgbe_hic_i2c_read *buffer)
@@ -103,7 +103,7 @@ static int txgbe_set_phy_link_hostif(struct wx *wx, int speed, int autoneg, int
103103
buffer.duplex = duplex;
104104

105105
return wx_host_interface_command(wx, (u32 *)&buffer, sizeof(buffer),
106-
WX_HI_COMMAND_TIMEOUT, true);
106+
WX_HI_COMMAND_TIMEOUT, false);
107107
}
108108

109109
static void txgbe_get_link_capabilities(struct wx *wx)

0 commit comments

Comments
 (0)