Skip to content

Commit ab83c9c

Browse files
abelvesagregkh
authored andcommitted
clk: qcom: gcc-x1e80100: Fix USB MP SS1 PHY GDSC pwrsts flags
commit e7f37a7 upstream. Allowing these GDSCs to collapse makes the QMP combo PHYs lose their configuration on machine suspend. Currently, the QMP combo PHY driver doesn't reinitialise the HW on resume. Under such conditions, the USB SuperSpeed support is broken. To avoid this, mark the pwrsts flags with RET_ON. This has been already done for USB 0 and 1 SS PHY GDSCs, Do this also for the USB MP SS1 PHY GDSC config. The USB MP SS0 PHY GDSC already has it. Fixes: 161b7c4 ("clk: qcom: Add Global Clock controller (GCC) driver for X1E80100") Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> Link: https://lore.kernel.org/r/20241021-x1e80100-clk-gcc-fix-usb-mp-phy-gdsc-pwrsts-flags-v2-1-0bfd64556238@linaro.org Signed-off-by: Bjorn Andersson <andersson@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 1ddbc8e commit ab83c9c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/clk/qcom/gcc-x1e80100.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6155,7 +6155,7 @@ static struct gdsc gcc_usb3_mp_ss1_phy_gdsc = {
61556155
.pd = {
61566156
.name = "gcc_usb3_mp_ss1_phy_gdsc",
61576157
},
6158-
.pwrsts = PWRSTS_OFF_ON,
6158+
.pwrsts = PWRSTS_RET_ON,
61596159
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
61606160
};
61616161

0 commit comments

Comments
 (0)