Skip to content

Commit ac5ae0a

Browse files
aheevjenswi-linaro
authored andcommitted
tee: qcomtee: fix uninitialized pointers with free attribute
Uninitialized pointers with `__free` attribute can cause undefined behavior as the memory assigned randomly to the pointer is freed automatically when the pointer goes out of scope. qcomtee doesn't have any bugs related to this as of now, but it is better to initialize and assign pointers with `__free` attribute in one statement to ensure proper scope-based cleanup Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/all/aPiG_F5EBQUjZqsl@stanley.mountain/ Signed-off-by: Ally Heev <allyheev@gmail.com> Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
1 parent 3a86608 commit ac5ae0a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/tee/qcomtee/call.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ static void qcomtee_get_version(struct tee_device *teedev,
645645
static void qcomtee_get_qtee_feature_list(struct tee_context *ctx, u32 id,
646646
u32 *version)
647647
{
648-
struct qcomtee_object_invoke_ctx *oic __free(kfree);
648+
struct qcomtee_object_invoke_ctx *oic __free(kfree) = NULL;
649649
struct qcomtee_object *client_env, *service;
650650
struct qcomtee_arg u[3] = { 0 };
651651
int result;

0 commit comments

Comments
 (0)