Skip to content

Commit add03fd

Browse files
computersforpeaceKAGA-KOKO
authored andcommitted
genirq/test: Drop CONFIG_GENERIC_IRQ_MIGRATION assumptions
Not all platforms use the generic IRQ migration code, even if they select GENERIC_IRQ_MIGRATION. (See, for example, powerpc / pseries_cpu_disable().) If such platforms don't perform managed shutdown the same way, the interrupt may not actually shut down, and these tests fail: [ 4.357022][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:211 [ 4.357022][ T101] Expected irqd_is_activated(data) to be false, but is true [ 4.358128][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:212 [ 4.358128][ T101] Expected irqd_is_started(data) to be false, but is true [ 4.375558][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:216 [ 4.375558][ T101] Expected irqd_is_activated(data) to be false, but is true [ 4.376088][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:217 [ 4.376088][ T101] Expected irqd_is_started(data) to be false, but is true [ 4.377851][ T1] # irq_cpuhotplug_test: pass:0 fail:1 skip:0 total:1 [ 4.377901][ T1] not ok 4 irq_cpuhotplug_test [ 4.378073][ T1] # irq_test_cases: pass:3 fail:1 skip:0 total:4 Rather than test that PowerPC performs migration the same way as the unterrupt core, just drop the state checks. The point of the test was to ensure that the code kept |depth| balanced, which still can be tested for. Fixes: 66067c3 ("genirq: Add kunit tests for depth counts") Reported-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Brian Norris <briannorris@chromium.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Tested-by: Guenter Roeck <linux@roeck-us.net> Reviewed-by: David Gow <davidgow@google.com> Link: https://lore.kernel.org/all/20250822190140.2154646-6-briannorris@chromium.org
1 parent 0c888bc commit add03fd

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

kernel/irq/irq_test.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -203,13 +203,9 @@ static void irq_cpuhotplug_test(struct kunit *test)
203203
KUNIT_EXPECT_EQ(test, desc->depth, 1);
204204

205205
KUNIT_EXPECT_EQ(test, remove_cpu(1), 0);
206-
KUNIT_EXPECT_FALSE(test, irqd_is_activated(data));
207-
KUNIT_EXPECT_FALSE(test, irqd_is_started(data));
208206
KUNIT_EXPECT_GE(test, desc->depth, 1);
209207
KUNIT_EXPECT_EQ(test, add_cpu(1), 0);
210208

211-
KUNIT_EXPECT_FALSE(test, irqd_is_activated(data));
212-
KUNIT_EXPECT_FALSE(test, irqd_is_started(data));
213209
KUNIT_EXPECT_EQ(test, desc->depth, 1);
214210

215211
enable_irq(virq);

0 commit comments

Comments
 (0)