Skip to content

Commit aef6ac1

Browse files
Su Huimartinkpetersen
authored andcommitted
scsi: aic7xxx: Return negative error codes in aic7770_probe()
aic7770_config() returns both negative and positive error codes. It's better to make aic7770_probe() only return negative error codes. A previous commit made ahc_linux_register_host() return negative error codes, which makes sure aic7770_probe() returns negative error codes. Signed-off-by: Su Hui <suhui@nfschina.com> Link: https://lore.kernel.org/r/20231201025955.1584260-4-suhui@nfschina.com Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 70dfaf8 commit aef6ac1

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/scsi/aic7xxx/aic7770_osm.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,17 +87,17 @@ aic7770_probe(struct device *dev)
8787
sprintf(buf, "ahc_eisa:%d", eisaBase >> 12);
8888
name = kstrdup(buf, GFP_ATOMIC);
8989
if (name == NULL)
90-
return (ENOMEM);
90+
return -ENOMEM;
9191
ahc = ahc_alloc(&aic7xxx_driver_template, name);
9292
if (ahc == NULL)
93-
return (ENOMEM);
93+
return -ENOMEM;
9494
ahc->dev = dev;
9595
error = aic7770_config(ahc, aic7770_ident_table + edev->id.driver_data,
9696
eisaBase);
9797
if (error != 0) {
9898
ahc->bsh.ioport = 0;
9999
ahc_free(ahc);
100-
return (error);
100+
return error < 0 ? error : -error;
101101
}
102102

103103
dev_set_drvdata(dev, ahc);

0 commit comments

Comments
 (0)