Skip to content

Commit af4c733

Browse files
q2venPaolo Abeni
authored andcommitted
af_unix: Annotate data-race of sk->sk_state in unix_stream_read_skb().
unix_stream_read_skb() is called from sk->sk_data_ready() context where unix_state_lock() is not held. Let's use READ_ONCE() there. Fixes: 77462de ("af_unix: Add read_sock for stream socket types") Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent 8a34d4e commit af4c733

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/unix/af_unix.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2659,7 +2659,7 @@ static struct sk_buff *manage_oob(struct sk_buff *skb, struct sock *sk,
26592659

26602660
static int unix_stream_read_skb(struct sock *sk, skb_read_actor_t recv_actor)
26612661
{
2662-
if (unlikely(sk->sk_state != TCP_ESTABLISHED))
2662+
if (unlikely(READ_ONCE(sk->sk_state) != TCP_ESTABLISHED))
26632663
return -ENOTCONN;
26642664

26652665
return unix_read_skb(sk, recv_actor);

0 commit comments

Comments
 (0)