drm/xe/debugfs: Add missing xe_pm_runtime_put in wedge_mode_set

ShuichengLin · rodrigovivi · commit b31e668d3111 · 2025-02-14T10:07:36.000-05:00
xe_pm_runtime_put is missed in the failure path. Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250213230322.1180621-1-shuicheng.lin@intel.com Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
@@ -176,6 +176,7 @@ static ssize_t wedged_mode_set(struct file *f, const char __user *ubuf,
 		ret = xe_guc_ads_scheduler_policy_toggle_reset(&gt->uc.guc.ads);
 		if (ret) {
 			xe_gt_err(gt, "Failed to update GuC ADS scheduler policy. GuC may still cause engine reset even with wedged_mode=2\n");
+			xe_pm_runtime_put(xe);
 			return -EIO;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -176,6 +176,7 @@ static ssize_t wedged_mode_set(struct file f, const char __user ubuf,`
`176`	`176`	`ret = xe_guc_ads_scheduler_policy_toggle_reset(&gt->uc.guc.ads);`
`177`	`177`	`if (ret) {`
`178`	`178`	`xe_gt_err(gt, "Failed to update GuC ADS scheduler policy. GuC may still cause engine reset even with wedged_mode=2\n");`
	`179`	`+ xe_pm_runtime_put(xe);`
`179`	`180`	`return -EIO;`
`180`	`181`	`}`
`181`	`182`	`}`