Skip to content

Commit b56aed4

Browse files
RadxaNaokimmind
authored andcommitted
Revert "arm64: dts: rockchip: remove redundant cd-gpios from rk3588 sdmmc nodes"
This reverts commit d859ad3. Inserting and removing microSD card is not detected since above commit. Reverting it fixes this problem. This is probably the same thing as 5 years ago on rk3399 https://lore.kernel.org/all/0608599d485117a9d99f5fb274fbb1b55f6ba9f7.1547466003.git.robin.murphy@arm.com/ So we'll go back to cd-gpios for now. this patch is tested on Radxa ROCK 5A and 5B. Fixes: d859ad3 ("arm64: dts: rockchip: remove redundant cd-gpios from rk3588 sdmmc nodes") Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> Link: https://lore.kernel.org/r/20240613001757.1350-1-naoki@radxa.com Signed-off-by: Heiko Stuebner <heiko@sntech.de>
1 parent cca46f8 commit b56aed4

4 files changed

Lines changed: 4 additions & 0 deletions

File tree

arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -444,6 +444,7 @@
444444
&sdmmc {
445445
bus-width = <4>;
446446
cap-sd-highspeed;
447+
cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
447448
disable-wp;
448449
max-frequency = <150000000>;
449450
no-sdio;

arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -435,6 +435,7 @@
435435
&sdmmc {
436436
bus-width = <4>;
437437
cap-sd-highspeed;
438+
cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
438439
disable-wp;
439440
max-frequency = <150000000>;
440441
no-sdio;

arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,7 @@
383383
bus-width = <4>;
384384
cap-mmc-highspeed;
385385
cap-sd-highspeed;
386+
cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
386387
disable-wp;
387388
sd-uhs-sdr104;
388389
vmmc-supply = <&vcc_3v3_s3>;

arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,7 @@
366366
bus-width = <4>;
367367
cap-mmc-highspeed;
368368
cap-sd-highspeed;
369+
cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
369370
disable-wp;
370371
max-frequency = <150000000>;
371372
no-sdio;

0 commit comments

Comments
 (0)