Skip to content

Commit b595974

Browse files
antheasJiri Kosina
authored andcommitted
HID: asus: add Z13 folio to generic group for multitouch to work
The Asus Z13 folio has a multitouch touchpad that needs to bind to the hid-multitouch driver in order to work properly. So bind it to the HID_GROUP_GENERIC group to release the touchpad and move it to the bottom so that the comment applies to it. While at it, change the generic KEYBOARD3 name to Z13_FOLIO. Reviewed-by: Luke D. Jones <luke@ljones.dev> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> Signed-off-by: Jiri Kosina <jkosina@suse.com>
1 parent 02d6eee commit b595974

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/hid/hid-asus.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1384,9 +1384,6 @@ static const struct hid_device_id asus_devices[] = {
13841384
{ HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,
13851385
USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD2),
13861386
QUIRK_USE_KBD_BACKLIGHT | QUIRK_ROG_NKEY_KEYBOARD },
1387-
{ HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,
1388-
USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD3),
1389-
QUIRK_USE_KBD_BACKLIGHT | QUIRK_ROG_NKEY_KEYBOARD },
13901387
{ HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,
13911388
USB_DEVICE_ID_ASUSTEK_ROG_Z13_LIGHTBAR),
13921389
QUIRK_USE_KBD_BACKLIGHT | QUIRK_ROG_NKEY_KEYBOARD },
@@ -1416,6 +1413,9 @@ static const struct hid_device_id asus_devices[] = {
14161413
* Note bind to the HID_GROUP_GENERIC group, so that we only bind to the keyboard
14171414
* part, while letting hid-multitouch.c handle the touchpad.
14181415
*/
1416+
{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
1417+
USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_Z13_FOLIO),
1418+
QUIRK_USE_KBD_BACKLIGHT | QUIRK_ROG_NKEY_KEYBOARD },
14191419
{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
14201420
USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_T101HA_KEYBOARD) },
14211421
{ }

drivers/hid/hid-ids.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@
223223
#define USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD3 0x1822
224224
#define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD 0x1866
225225
#define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD2 0x19b6
226-
#define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD3 0x1a30
226+
#define USB_DEVICE_ID_ASUSTEK_ROG_Z13_FOLIO 0x1a30
227227
#define USB_DEVICE_ID_ASUSTEK_ROG_Z13_LIGHTBAR 0x18c6
228228
#define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_ALLY 0x1abe
229229
#define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_ALLY_X 0x1b4c

0 commit comments

Comments
 (0)