drm/client: Fix error code in drm_client_buffer_vmap_local()

Dan Carpenter · tdz · commit b5fbf924f125 · 2024-07-29T08:50:23.000+02:00
This function accidentally returns zero/success on the failure path. It leads to locking issues and an uninitialized *map_copy in the caller. Fixes: b4b0193 ("drm/fbdev-generic: Fix locking with drm_client_buffer_vmap_local()") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Link: https://patchwork.freedesktop.org/patch/msgid/89d13df3-747c-4c5d-b122-d081aef5110a@stanley.mountain
diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
@@ -355,7 +355,7 @@ int drm_client_buffer_vmap_local(struct drm_client_buffer *buffer,
 
 err_drm_gem_vmap_unlocked:
 	drm_gem_unlock(gem);
-	return 0;
+	return ret;
 }
 EXPORT_SYMBOL(drm_client_buffer_vmap_local);
 

Original file line number	Diff line number	Diff line change
`@@ -355,7 +355,7 @@ int drm_client_buffer_vmap_local(struct drm_client_buffer *buffer,`
`355`	`355`
`356`	`356`	`err_drm_gem_vmap_unlocked:`
`357`	`357`	`drm_gem_unlock(gem);`
`358`		`- return 0;`
	`358`	`+ return ret;`
`359`	`359`	`}`
`360`	`360`	`EXPORT_SYMBOL(drm_client_buffer_vmap_local);`
`361`	`361`