drm/amdgpu/userq: need to unref bo

davidwuAMD · alexdeucher · commit b665f29a2f93 · 2025-11-06T09:56:25.000-05:00
unref bo after amdgpu_bo_reserve() failure as it has
called amdgpu_bo_ref() already

Reviewed-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
Signed-off-by: David (Ming Qiang) Wu &lt;David.Wu3@amd.com&gt;
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
@@ -386,6 +386,7 @@ static int amdgpu_userq_fence_read_wptr(struct amdgpu_usermode_queue *queue,
 	amdgpu_bo_unreserve(queue->vm->root.bo);
 	r = amdgpu_bo_reserve(bo, true);
 	if (r) {
+		amdgpu_bo_unref(&bo);
 		DRM_ERROR("Failed to reserve userqueue wptr bo");
 		return r;
 	}

Original file line number	Diff line number	Diff line change
`@@ -386,6 +386,7 @@ static int amdgpu_userq_fence_read_wptr(struct amdgpu_usermode_queue *queue,`
`386`	`386`	`amdgpu_bo_unreserve(queue->vm->root.bo);`
`387`	`387`	`r = amdgpu_bo_reserve(bo, true);`
`388`	`388`	`if (r) {`
	`389`	`+ amdgpu_bo_unref(&bo);`
`389`	`390`	`DRM_ERROR("Failed to reserve userqueue wptr bo");`
`390`	`391`	`return r;`
`391`	`392`	`}`