drm/i915/display: Add default case to mipi_exec_send_packet

Jonathan-Cavitt · jnikula · commit b84befa31266 · 2025-11-13T12:02:47.000+02:00
Add a default case to the switch case statement in mipi_exec_send_packet to prevent attempts to read an uninitialized ret value. It's unlikely the default case will ever occur during regular exeuction, but if more MIPI DSI Processor-to-Peripheral transaction types are ever added, then having this in place will be a useful safety guard. Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> Fixes: 23db157 ("drm/i915/dsi: log send packet sequence errors") Reviewed-by: Jani Nikula <jani.nikula@intel.com> Link: https://patch.msgid.link/20251104164150.16795-2-jonathan.cavitt@intel.com Signed-off-by: Jani Nikula <jani.nikula@intel.com>
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -171,6 +171,9 @@ static const u8 *mipi_exec_send_packet(struct intel_dsi *intel_dsi,
 	case MIPI_DSI_DCS_LONG_WRITE:
 		ret = mipi_dsi_dcs_write_buffer(dsi_device, data, len);
 		break;
+	default:
+		ret = -EINVAL;
+		break;
 	}
 
 	if (ret < 0)

Original file line number	Diff line number	Diff line change
`@@ -171,6 +171,9 @@ static const u8 mipi_exec_send_packet(struct intel_dsi intel_dsi,`
`171`	`171`	`case MIPI_DSI_DCS_LONG_WRITE:`
`172`	`172`	`ret = mipi_dsi_dcs_write_buffer(dsi_device, data, len);`
`173`	`173`	`break;`
	`174`	`+ default:`
	`175`	`+ ret = -EINVAL;`
	`176`	`+ break;`
`174`	`177`	`}`
`175`	`178`
`176`	`179`	`if (ret < 0)`