Skip to content

Commit b894a64

Browse files
marcanjannau
authored andcommitted
PCI: apple: Use gpiod_set_value_cansleep in probe flow
We're allowed to sleep here, so tell the GPIO core by using gpiod_set_value_cansleep instead of gpiod_set_value. Fixes: 1e33888 ("PCI: apple: Add initial hardware bring-up") Acked-by: Marc Zyngier <maz@kernel.org> Signed-off-by: Hector Martin <marcan@marcan.st>
1 parent 7d11b1a commit b894a64

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/pci/controller/pcie-apple.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie,
541541
rmw_set(PORT_APPCLK_EN, port->base + PORT_APPCLK);
542542

543543
/* Assert PERST# before setting up the clock */
544-
gpiod_set_value(reset, 1);
544+
gpiod_set_value_cansleep(reset, 1);
545545

546546
ret = apple_pcie_setup_refclk(pcie, port);
547547
if (ret < 0)
@@ -552,7 +552,7 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie,
552552

553553
/* Deassert PERST# */
554554
rmw_set(PORT_PERST_OFF, port->base + PORT_PERST);
555-
gpiod_set_value(reset, 0);
555+
gpiod_set_value_cansleep(reset, 0);
556556

557557
/* Wait for 100ms after PERST# deassertion (PCIe r5.0, 6.6.1) */
558558
msleep(100);

0 commit comments

Comments
 (0)