Skip to content

Commit bb57f67

Browse files
ashishmhetre8joergroedel
authored andcommitted
iommu: Don't reserve 0-length IOVA region
When the bootloader/firmware doesn't setup the framebuffers, their address and size are 0 in "iommu-addresses" property. If IOVA region is reserved with 0 length, then it ends up corrupting the IOVA rbtree with an entry which has pfn_hi < pfn_lo. If we intend to use display driver in kernel without framebuffer then it's causing the display IOMMU mappings to fail as entire valid IOVA space is reserved when address and length are passed as 0. An ideal solution would be firmware removing the "iommu-addresses" property and corresponding "memory-region" if display is not present. But the kernel should be able to handle this by checking for size of IOVA region and skipping the IOVA reservation if size is 0. Also, add a warning if firmware is requesting 0-length IOVA region reservation. Fixes: a5bf3cf ("iommu: Implement of_iommu_get_resv_regions()") Signed-off-by: Ashish Mhetre <amhetre@nvidia.com> Acked-by: Robin Murphy <robin.murphy@arm.com> Link: https://lore.kernel.org/r/20231205065656.9544-1-amhetre@nvidia.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 9991a82 commit bb57f67

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

drivers/iommu/of_iommu.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,10 @@ void of_iommu_get_resv_regions(struct device *dev, struct list_head *list)
252252
prot |= IOMMU_CACHE;
253253

254254
maps = of_translate_dma_region(np, maps, &iova, &length);
255+
if (length == 0) {
256+
dev_warn(dev, "Cannot reserve IOVA region of 0 size\n");
257+
continue;
258+
}
255259
type = iommu_resv_region_get_type(dev, &phys, iova, length);
256260

257261
region = iommu_alloc_resv_region(iova, length, prot, type,

0 commit comments

Comments
 (0)