Skip to content

Commit bc089c4

Browse files
committed
tracing: Convert function graph set_flags() to use a switch() statement
Currently the set_flags() of the function graph tracer has a bunch of: if (bit == FLAG1) { [..] } if (bit == FLAG2) { [..] } To clean it up a bit, convert it over to a switch statement. Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Andrew Morton <akpm@linux-foundation.org> Link: https://patch.msgid.link/20251114192319.117123664@kernel.org Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent 5abb6cc commit bc089c4

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

kernel/trace/trace_functions_graph.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1664,27 +1664,29 @@ func_graph_set_flag(struct trace_array *tr, u32 old_flags, u32 bit, int set)
16641664
if (!!set == !!(tr->current_trace_flags->val & bit))
16651665
return 0;
16661666

1667-
if (bit == TRACE_GRAPH_SLEEP_TIME) {
1667+
switch (bit) {
1668+
case TRACE_GRAPH_SLEEP_TIME:
16681669
if (set) {
16691670
fgraph_no_sleep_time--;
16701671
if (WARN_ON_ONCE(fgraph_no_sleep_time < 0))
16711672
fgraph_no_sleep_time = 0;
16721673
} else {
16731674
fgraph_no_sleep_time++;
16741675
}
1675-
}
1676+
break;
16761677

1677-
if (bit == TRACE_GRAPH_PRINT_IRQS) {
1678+
case TRACE_GRAPH_PRINT_IRQS:
16781679
if (set)
16791680
ftrace_graph_skip_irqs--;
16801681
else
16811682
ftrace_graph_skip_irqs++;
16821683
if (WARN_ON_ONCE(ftrace_graph_skip_irqs < 0))
16831684
ftrace_graph_skip_irqs = 0;
1684-
}
1685+
break;
16851686

1686-
if (bit == TRACE_GRAPH_ARGS)
1687+
case TRACE_GRAPH_ARGS:
16871688
return ftrace_graph_trace_args(tr, set);
1689+
}
16881690

16891691
return 0;
16901692
}

0 commit comments

Comments
 (0)