drm: apple: dptx: Issue HPD event early on gpio/type-c disconnect

Atomic modesets during a display disconnect may result in unrecoverable
state if the set_digital_out_mode() DCP firmware call fails. Mark the
connector as early as possible as disconnected to make this more
unlikely.
TODO: investigate set_digital_out_mode() failure handling

Signed-off-by: Janne Grunau <j@jannau.net>

Author: jannau

drivers/gpu/drm/apple/dcp.c

@@ -424,6 +424,14 @@ static int dcp_dptx_connect(struct apple_dcp *dcp, u32 port)
 	return ret;
 }
 
+static void disconnected_hpd_event(struct apple_connector *con)
+{
+	if (con) {
+		con->connected = 0;
+		drm_kms_helper_connector_hotplug_event(&con->base);
+	}
+}
+
 static int dcp_dptx_disconnect(struct apple_dcp *dcp, u32 port)
 {
 	dev_info(dcp->dev, "%s(port=%d)\n", __func__, port);
@@ -448,6 +456,9 @@ EXPORT_SYMBOL_GPL(dcp_dptx_connect_oob);
 int dcp_dptx_disconnect_oob(struct platform_device *pdev, u32 port)
 {
 	struct apple_dcp *dcp = platform_get_drvdata(pdev);
+
+	disconnected_hpd_event(dcp->connector);
+
 	if (dcp->avep)
 		av_service_disconnect(dcp);
 	dptxport_set_hpd(dcp->dptxport[port].service, false);
@@ -671,8 +682,10 @@ void dcp_poweroff(struct platform_device *pdev)
 
 	if (dcp->hdmi_hpd) {
 		bool connected = gpiod_get_value_cansleep(dcp->hdmi_hpd);
-		if (!connected)
+		if (!connected) {
+			disconnected_hpd_event(dcp->connector);
 			dcp_dptx_disconnect(dcp, 0);
+		}
 	}
 }
 EXPORT_SYMBOL(dcp_poweroff);
@@ -1257,6 +1270,7 @@ static int dcp_platform_suspend(struct device *dev)
 
 	if (dcp->hdmi_hpd_irq) {
 		disable_irq(dcp->hdmi_hpd_irq);
+		disconnected_hpd_event(dcp->connector);
 		dcp_dptx_disconnect(dcp, 0);
 	}
 	/*