Skip to content

Commit c00d8b7

Browse files
YuanShangalexdeucher
authored andcommitted
drm/amdgpu: Retain job->vm in amdgpu_job_prepare_job
The field job->vm is used in function amdgpu_job_run to get the page table re-generation counter and decide whether the job should be skipped. Specifically, function amdgpu_vm_generation checks if the VM is valid for this job to use. For instance, if a gfx job depends on a cancelled sdma job from entity vm->delayed, then the gfx job should be skipped. Fixes: 26c95e8 ("drm/amdgpu: set the VM pointer to NULL in amdgpu_job_prepare") Signed-off-by: YuanShang <YuanShang.Mao@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> (cherry picked from commit ed76936) Cc: stable@vger.kernel.org
1 parent 1c8dc3e commit c00d8b7

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

drivers/gpu/drm/amd/amdgpu/amdgpu_job.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -365,13 +365,6 @@ amdgpu_job_prepare_job(struct drm_sched_job *sched_job,
365365
dev_err(ring->adev->dev, "Error getting VM ID (%d)\n", r);
366366
goto error;
367367
}
368-
/*
369-
* The VM structure might be released after the VMID is
370-
* assigned, we had multiple problems with people trying to use
371-
* the VM pointer so better set it to NULL.
372-
*/
373-
if (!fence)
374-
job->vm = NULL;
375368
return fence;
376369
}
377370

0 commit comments

Comments
 (0)