Skip to content

Commit c0fbc0a

Browse files
ceggers-arrigregkh
authored andcommitted
ARM: 9444/1: add KEEP() keyword to ARM_VECTORS
commit c3d944a upstream. Without this, the vectors are removed if LD_DEAD_CODE_DATA_ELIMINATION is enabled. At startup, the CPU (silently) hangs in the undefined instruction exception as soon as the first timer interrupt arrives. On my setup, the system also boots fine without the 2nd and 3rd KEEP() statements, so I cannot tell whether these are actually required. [nathan: Use OVERLAY_KEEP() to avoid breaking old ld.lld versions] Cc: stable@vger.kernel.org Fixes: ed0f941 ("ARM: 9404/1: arm32: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION") Signed-off-by: Christian Eggers <ceggers@arri.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a90301a commit c0fbc0a

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

arch/arm/include/asm/vmlinux.lds.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,13 +131,13 @@
131131
__vectors_lma = .; \
132132
OVERLAY 0xffff0000 : NOCROSSREFS AT(__vectors_lma) { \
133133
.vectors { \
134-
*(.vectors) \
134+
OVERLAY_KEEP(*(.vectors)) \
135135
} \
136136
.vectors.bhb.loop8 { \
137-
*(.vectors.bhb.loop8) \
137+
OVERLAY_KEEP(*(.vectors.bhb.loop8)) \
138138
} \
139139
.vectors.bhb.bpiall { \
140-
*(.vectors.bhb.bpiall) \
140+
OVERLAY_KEEP(*(.vectors.bhb.bpiall)) \
141141
} \
142142
} \
143143
ARM_LMA(__vectors, .vectors); \

0 commit comments

Comments
 (0)