Input: cypress_ps2 - clean up setting reporting rate

dtor · dtor · commit c1a339001191 · 2024-07-03T13:48:53.000-07:00
Casting an integer field containing desired rate to a pointer to bytes works on little endian architectures where the driver is used, but not a good practice. Use a temporary of proper type instead. Link: https://lore.kernel.org/r/20240628224728.2180126-1-dmitry.torokhov@gmail.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
diff --git a/drivers/input/mouse/cypress_ps2.c b/drivers/input/mouse/cypress_ps2.c
@@ -612,6 +612,7 @@ static psmouse_ret_t cypress_protocol_handler(struct psmouse *psmouse)
 static void cypress_set_rate(struct psmouse *psmouse, unsigned int rate)
 {
 	struct cytp_data *cytp = psmouse->private;
+	u8 rate_param;
 
 	if (rate >= 80) {
 		psmouse->rate = 80;
@@ -621,8 +622,8 @@ static void cypress_set_rate(struct psmouse *psmouse, unsigned int rate)
 		cytp->mode &= ~CYTP_BIT_HIGH_RATE;
 	}
 
-	ps2_command(&psmouse->ps2dev, (unsigned char *)&psmouse->rate,
-		    PSMOUSE_CMD_SETRATE);
+	rate_param = (u8)rate;
+	ps2_command(&psmouse->ps2dev, &rate_param, PSMOUSE_CMD_SETRATE);
 }
 
 static void cypress_disconnect(struct psmouse *psmouse)

Original file line number	Diff line number	Diff line change
`@@ -612,6 +612,7 @@ static psmouse_ret_t cypress_protocol_handler(struct psmouse *psmouse)`
`612`	`612`	`static void cypress_set_rate(struct psmouse *psmouse, unsigned int rate)`
`613`	`613`	`{`
`614`	`614`	`struct cytp_data *cytp = psmouse->private;`
	`615`	`+ u8 rate_param;`
`615`	`616`
`616`	`617`	`if (rate >= 80) {`
`617`	`618`	`psmouse->rate = 80;`
`@@ -621,8 +622,8 @@ static void cypress_set_rate(struct psmouse *psmouse, unsigned int rate)`
`621`	`622`	`cytp->mode &= ~CYTP_BIT_HIGH_RATE;`
`622`	`623`	`}`
`623`	`624`
`624`		`- ps2_command(&psmouse->ps2dev, (unsigned char *)&psmouse->rate,`
`625`		`- PSMOUSE_CMD_SETRATE);`
	`625`	`+ rate_param = (u8)rate;`
	`626`	`+ ps2_command(&psmouse->ps2dev, &rate_param, PSMOUSE_CMD_SETRATE);`
`626`	`627`	`}`
`627`	`628`
`628`	`629`	`static void cypress_disconnect(struct psmouse *psmouse)`