Skip to content

Commit c35d86a

Browse files
amorenozkuba-moo
authored andcommitted
net: psample: skip packet copy if no listeners
If nobody is listening on the multicast group, generating the sample, which involves copying packet data, seems completely unnecessary. Return fast in this case. Reviewed-by: Aaron Conole <aconole@redhat.com> Acked-by: Eelco Chaudron <echaudro@redhat.com> Reviewed-by: Ido Schimmel <idosch@nvidia.com> Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: Adrian Moreno <amorenoz@redhat.com> Link: https://patch.msgid.link/20240704085710.353845-4-amorenoz@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 0344844 commit c35d86a

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

net/psample/psample.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,10 @@ void psample_sample_packet(struct psample_group *group, struct sk_buff *skb,
376376
void *data;
377377
int ret;
378378

379+
if (!genl_has_listeners(&psample_nl_family, group->net,
380+
PSAMPLE_NL_MCGRP_SAMPLE))
381+
return;
382+
379383
meta_len = (in_ifindex ? nla_total_size(sizeof(u16)) : 0) +
380384
(out_ifindex ? nla_total_size(sizeof(u16)) : 0) +
381385
(md->out_tc_valid ? nla_total_size(sizeof(u16)) : 0) +

0 commit comments

Comments
 (0)