Skip to content

Commit c4d08cf

Browse files
Wolfram Sanggroeck
authored andcommitted
hwmon: (lm75) simplify lm75_write_config()
After previous refactoring, it is now possible to make lm75_write_config() a simple inline function. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/20241219225522.3490-8-wsa+renesas@sang-engineering.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 6da24a2 commit c4d08cf

1 file changed

Lines changed: 4 additions & 10 deletions

File tree

drivers/hwmon/lm75.c

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -340,17 +340,11 @@ static inline long lm75_reg_to_mc(s16 temp, u8 resolution)
340340
return ((temp >> (16 - resolution)) * 1000) >> (resolution - 8);
341341
}
342342

343-
static int lm75_write_config(struct lm75_data *data, u16 set_mask,
344-
u16 clr_mask)
343+
static inline int lm75_write_config(struct lm75_data *data, u16 set_mask,
344+
u16 clr_mask)
345345
{
346-
int err;
347-
348-
err = regmap_update_bits(data->regmap, LM75_REG_CONF,
349-
clr_mask | LM75_SHUTDOWN, set_mask);
350-
if (err)
351-
return err;
352-
353-
return 0;
346+
return regmap_update_bits(data->regmap, LM75_REG_CONF,
347+
clr_mask | LM75_SHUTDOWN, set_mask);
354348
}
355349

356350
static irqreturn_t lm75_alarm_handler(int irq, void *private)

0 commit comments

Comments
 (0)