Skip to content

Commit c5f7d46

Browse files
dtorij-intel
authored andcommitted
platform/x86: x86-android-tablets: convert Wacom devices to GPIO references
Now that gpiolib supports software nodes to describe GPIOs, switch the driver away from using GPIO lookup tables for Wacom touchscreens to using PROPERTY_ENTRY_GPIO() to keep all touchscreen properties together. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Tested-by: Hans de Goede <hansg@kernel.org> Reviewed-by: Hans de Goede <hansg@kernel.org> Reviewed-by: Andy Shevchenko <andy@kernel.org> Signed-off-by: Hans de Goede <hansg@kernel.org> Link: https://patch.msgid.link/20250920200713.20193-3-hansg@kernel.org Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
1 parent b40088b commit c5f7d46

1 file changed

Lines changed: 1 addition & 9 deletions

File tree

  • drivers/platform/x86/x86-android-tablets

drivers/platform/x86/x86-android-tablets/lenovo.c

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ static const struct software_node lenovo_yb1_x90_goodix_node = {
7575
static const struct property_entry lenovo_yb1_x90_wacom_props[] = {
7676
PROPERTY_ENTRY_U32("hid-descr-addr", 0x0001),
7777
PROPERTY_ENTRY_U32("post-reset-deassert-delay-ms", 150),
78+
PROPERTY_ENTRY_GPIO("reset-gpios", &cherryview_gpiochip_nodes[0], 82, GPIO_ACTIVE_LOW),
7879
{ }
7980
};
8081

@@ -218,17 +219,8 @@ static struct gpiod_lookup_table lenovo_yb1_x90_hideep_gpios = {
218219
},
219220
};
220221

221-
static struct gpiod_lookup_table lenovo_yb1_x90_wacom_gpios = {
222-
.dev_id = "i2c-wacom",
223-
.table = {
224-
GPIO_LOOKUP("INT33FF:00", 82, "reset", GPIO_ACTIVE_LOW),
225-
{ }
226-
},
227-
};
228-
229222
static struct gpiod_lookup_table * const lenovo_yb1_x90_gpios[] = {
230223
&lenovo_yb1_x90_hideep_gpios,
231-
&lenovo_yb1_x90_wacom_gpios,
232224
NULL
233225
};
234226

0 commit comments

Comments
 (0)