Skip to content

Commit c5fccfe

Browse files
damien-lemoalfloatious
authored andcommitted
ata: libata-eh: use bool for fastdrain in ata_eh_set_pending()
Use the bool type for the fastdrain argument of ata_eh_set_pending(), as it should be. No functional changes. Signed-off-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Niklas Cassel <cassel@kernel.org> Link: https://lore.kernel.org/r/20250704104552.310630-1-dlemoal@kernel.org Signed-off-by: Niklas Cassel <cassel@kernel.org>
1 parent 7aae547 commit c5fccfe

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/ata/libata-eh.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -907,7 +907,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list *t)
907907
* LOCKING:
908908
* spin_lock_irqsave(host lock)
909909
*/
910-
static void ata_eh_set_pending(struct ata_port *ap, int fastdrain)
910+
static void ata_eh_set_pending(struct ata_port *ap, bool fastdrain)
911911
{
912912
unsigned int cnt;
913913

@@ -947,7 +947,7 @@ void ata_qc_schedule_eh(struct ata_queued_cmd *qc)
947947
struct ata_port *ap = qc->ap;
948948

949949
qc->flags |= ATA_QCFLAG_EH;
950-
ata_eh_set_pending(ap, 1);
950+
ata_eh_set_pending(ap, true);
951951

952952
/* The following will fail if timeout has already expired.
953953
* ata_scsi_error() takes care of such scmds on EH entry.
@@ -969,7 +969,7 @@ void ata_std_sched_eh(struct ata_port *ap)
969969
if (ap->pflags & ATA_PFLAG_INITIALIZING)
970970
return;
971971

972-
ata_eh_set_pending(ap, 1);
972+
ata_eh_set_pending(ap, true);
973973
scsi_schedule_eh(ap->scsi_host);
974974

975975
trace_ata_std_sched_eh(ap);
@@ -1020,7 +1020,7 @@ static int ata_do_link_abort(struct ata_port *ap, struct ata_link *link)
10201020
int tag, nr_aborted = 0;
10211021

10221022
/* we're gonna abort all commands, no need for fast drain */
1023-
ata_eh_set_pending(ap, 0);
1023+
ata_eh_set_pending(ap, false);
10241024

10251025
/* include internal tag in iteration */
10261026
ata_qc_for_each_with_internal(ap, qc, tag) {

0 commit comments

Comments
 (0)