Skip to content

Commit c67f8a1

Browse files
bijudasdtor
authored andcommitted
Input: da9063 - use dev_err_probe()
Replace dev_err()->dev_err_probe() to simplify probe(). Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Link: https://lore.kernel.org/r/20231213214803.9931-4-biju.das.jz@bp.renesas.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent bd2334e commit c67f8a1

1 file changed

Lines changed: 6 additions & 9 deletions

File tree

drivers/input/misc/da9063_onkey.c

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -195,10 +195,9 @@ static int da9063_onkey_probe(struct platform_device *pdev)
195195
onkey->dev = &pdev->dev;
196196

197197
onkey->regmap = dev_get_regmap(pdev->dev.parent, NULL);
198-
if (!onkey->regmap) {
199-
dev_err(&pdev->dev, "Parent regmap unavailable.\n");
200-
return -ENXIO;
201-
}
198+
if (!onkey->regmap)
199+
return dev_err_probe(&pdev->dev, -ENXIO,
200+
"Parent regmap unavailable.\n");
202201

203202
onkey->key_power = !of_property_read_bool(pdev->dev.of_node,
204203
"dlg,disable-key-power");
@@ -228,11 +227,9 @@ static int da9063_onkey_probe(struct platform_device *pdev)
228227
NULL, da9063_onkey_irq_handler,
229228
IRQF_TRIGGER_LOW | IRQF_ONESHOT,
230229
"ONKEY", onkey);
231-
if (error) {
232-
dev_err(&pdev->dev,
233-
"Failed to request IRQ %d: %d\n", irq, error);
234-
return error;
235-
}
230+
if (error)
231+
return dev_err_probe(&pdev->dev, error,
232+
"Failed to allocate onkey IRQ\n");
236233

237234
error = dev_pm_set_wake_irq(&pdev->dev, irq);
238235
if (error)

0 commit comments

Comments
 (0)