Skip to content

Commit c7b626a

Browse files
AaronDotbroonie
authored andcommitted
ASoC: loongson: Replace if with ternary operator
Replace an if statement with a ternary operator, making the code a tiny bit shorter. Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> Link: https://patch.msgid.link/94ec2ac178610f50af4815ef5b719695915bba31.1725844530.git.zhoubinbin@loongson.cn Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent e28ee1b commit c7b626a

1 file changed

Lines changed: 10 additions & 14 deletions

File tree

sound/soc/loongson/loongson_i2s.c

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,34 +21,30 @@
2121
SNDRV_PCM_FMTBIT_S20_3LE | \
2222
SNDRV_PCM_FMTBIT_S24_LE)
2323

24+
#define LOONGSON_I2S_TX_ENABLE (I2S_CTRL_TX_EN | I2S_CTRL_TX_DMA_EN)
25+
#define LOONGSON_I2S_RX_ENABLE (I2S_CTRL_RX_EN | I2S_CTRL_RX_DMA_EN)
26+
2427
static int loongson_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
2528
struct snd_soc_dai *dai)
2629
{
2730
struct loongson_i2s *i2s = snd_soc_dai_get_drvdata(dai);
31+
unsigned int mask;
2832
int ret = 0;
2933

3034
switch (cmd) {
3135
case SNDRV_PCM_TRIGGER_START:
3236
case SNDRV_PCM_TRIGGER_RESUME:
3337
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
34-
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
35-
regmap_update_bits(i2s->regmap, LS_I2S_CTRL,
36-
I2S_CTRL_TX_EN | I2S_CTRL_TX_DMA_EN,
37-
I2S_CTRL_TX_EN | I2S_CTRL_TX_DMA_EN);
38-
else
39-
regmap_update_bits(i2s->regmap, LS_I2S_CTRL,
40-
I2S_CTRL_RX_EN | I2S_CTRL_RX_DMA_EN,
41-
I2S_CTRL_RX_EN | I2S_CTRL_RX_DMA_EN);
38+
mask = (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) ?
39+
LOONGSON_I2S_TX_ENABLE : LOONGSON_I2S_RX_ENABLE;
40+
regmap_update_bits(i2s->regmap, LS_I2S_CTRL, mask, mask);
4241
break;
4342
case SNDRV_PCM_TRIGGER_STOP:
4443
case SNDRV_PCM_TRIGGER_SUSPEND:
4544
case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
46-
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
47-
regmap_update_bits(i2s->regmap, LS_I2S_CTRL,
48-
I2S_CTRL_TX_EN | I2S_CTRL_TX_DMA_EN, 0);
49-
else
50-
regmap_update_bits(i2s->regmap, LS_I2S_CTRL,
51-
I2S_CTRL_RX_EN | I2S_CTRL_RX_DMA_EN, 0);
45+
mask = (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) ?
46+
LOONGSON_I2S_TX_ENABLE : LOONGSON_I2S_RX_ENABLE;
47+
regmap_update_bits(i2s->regmap, LS_I2S_CTRL, mask, 0);
5248
break;
5349
default:
5450
ret = -EINVAL;

0 commit comments

Comments
 (0)