Skip to content

Commit c7bc7e9

Browse files
pengdonglinrafaeljw
authored andcommitted
ACPI: APEI: Remove redundant rcu_read_lock/unlock() under spinlock
Since commit a8bb74a ("rcu: Consolidate RCU-sched update-side function definitions") there is no difference between rcu_read_lock(), rcu_read_lock_bh() and rcu_read_lock_sched() in terms of RCU read section and the relevant grace period. That means that spin_lock(), which implies rcu_read_lock_sched(), also implies rcu_read_lock(). There is no need no explicitly start a RCU read section if one has already been started implicitly by spin_lock(). Simplify the code and remove the inner rcu_read_lock() invocation. Signed-off-by: pengdonglin <pengdonglin@xiaomi.com> Signed-off-by: pengdonglin <dolinux.peng@gmail.com> Reviewed-by: Hanjun Guo <guohanjun@huawei.com> Link: https://patch.msgid.link/20250916044735.2316171-2-dolinux.peng@gmail.com [ rjw: Subject adjustment ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 7d444f5 commit c7bc7e9

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/acpi/apei/ghes.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1207,12 +1207,10 @@ static int ghes_notify_hed(struct notifier_block *this, unsigned long event,
12071207
int ret = NOTIFY_DONE;
12081208

12091209
spin_lock_irqsave(&ghes_notify_lock_irq, flags);
1210-
rcu_read_lock();
12111210
list_for_each_entry_rcu(ghes, &ghes_hed, list) {
12121211
if (!ghes_proc(ghes))
12131212
ret = NOTIFY_OK;
12141213
}
1215-
rcu_read_unlock();
12161214
spin_unlock_irqrestore(&ghes_notify_lock_irq, flags);
12171215

12181216
return ret;

0 commit comments

Comments
 (0)