Skip to content

Commit c8798cc

Browse files
ColinIanKinggregkh
authored andcommitted
media: i2c: ds90ub960: Fix missing return check on ub960_rxport_read call
[ Upstream commit 24ad2d1 ] The function ub960_rxport_read is being called and afterwards ret is being checked for any failures, however ret is not being assigned to the return of the function call. Fix this by assigning ret to the return of the call which appears to be missing. Fixes: afe267f ("media: i2c: add DS90UB960 driver") Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 3035729 commit c8798cc

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/media/i2c/ds90ub960.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1286,7 +1286,7 @@ static int ub960_rxport_get_strobe_pos(struct ub960_data *priv,
12861286

12871287
clk_delay += v & UB960_IR_RX_ANA_STROBE_SET_CLK_DELAY_MASK;
12881288

1289-
ub960_rxport_read(priv, nport, UB960_RR_SFILTER_STS_1, &v);
1289+
ret = ub960_rxport_read(priv, nport, UB960_RR_SFILTER_STS_1, &v);
12901290
if (ret)
12911291
return ret;
12921292

0 commit comments

Comments
 (0)