Skip to content

Commit c8fb5a5

Browse files
Dan CarpenterBartosz Golaszewski
authored andcommitted
gpio: rtd: Fix signedness bug in probe
The "data->irqs[]" array holds unsigned int so this error handling will not work correctly. Fixes: eee636b ("gpio: rtd: Add support for Realtek DHC(Digital Home Center) RTD SoCs") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
1 parent 576db73 commit c8fb5a5

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

drivers/gpio/gpio-rtd.c

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -525,18 +525,21 @@ static int rtd_gpio_probe(struct platform_device *pdev)
525525
struct device *dev = &pdev->dev;
526526
struct gpio_irq_chip *irq_chip;
527527
struct rtd_gpio *data;
528+
int ret;
528529

529530
data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
530531
if (!data)
531532
return -ENOMEM;
532533

533-
data->irqs[0] = platform_get_irq(pdev, 0);
534-
if (data->irqs[0] < 0)
535-
return data->irqs[0];
534+
ret = platform_get_irq(pdev, 0);
535+
if (ret < 0)
536+
return ret;
537+
data->irqs[0] = ret;
536538

537-
data->irqs[1] = platform_get_irq(pdev, 1);
538-
if (data->irqs[1] < 0)
539-
return data->irqs[1];
539+
ret = platform_get_irq(pdev, 1);
540+
if (ret < 0)
541+
return ret;
542+
data->irqs[1] = ret;
540543

541544
data->info = device_get_match_data(dev);
542545
if (!data->info)

0 commit comments

Comments
 (0)