Skip to content

Commit ca90147

Browse files
plappermauldlezcano
authored andcommitted
clocksource/drivers/timer-rtl-otto: Drop set_counter function
The current counter value is a read only register. It will be reset when writing a new target timer value with rttm_set_period(). rttm_set_counter() is essentially a noop. Drop it. While this makes rttm_start_timer() and rttm_enable_timer() the same functions keep both to make the established abstraction layers for register and control functions active. Downstream has already tested and confirmed a patch. See openwrt/openwrt#19468 https://forum.openwrt.org/t/support-for-rtl838x-based-managed-switches/57875/3788 Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Tested-by: Stephen Howell <howels@allthatwemight.be> Tested-by: Bjørn Mork <bjorn@mork.no> Link: https://lore.kernel.org/r/20250804080328.2609287-3-markus.stockhausen@gmx.de
1 parent e7a2510 commit ca90147

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

drivers/clocksource/timer-rtl-otto.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,6 @@ struct rttm_cs {
5656
};
5757

5858
/* Simple internal register functions */
59-
static inline void rttm_set_counter(void __iomem *base, unsigned int counter)
60-
{
61-
iowrite32(counter, base + RTTM_CNT);
62-
}
63-
6459
static inline unsigned int rttm_get_counter(void __iomem *base)
6560
{
6661
return ioread32(base + RTTM_CNT);
@@ -137,7 +132,6 @@ static void rttm_stop_timer(void __iomem *base)
137132

138133
static void rttm_start_timer(struct timer_of *to, u32 mode)
139134
{
140-
rttm_set_counter(to->of_base.base, 0);
141135
rttm_enable_timer(to->of_base.base, mode, to->of_clk.rate / RTTM_TICKS_PER_SEC);
142136
}
143137

0 commit comments

Comments
 (0)