Skip to content

Commit cb31c58

Browse files
huthtdz
authored andcommitted
drm/fbdev-dma: Fix framebuffer mode for big endian devices
The drm_mode_legacy_fb_format() function only generates formats suitable for little endian devices. switch to drm_driver_legacy_fb_format() here instead to take the device endianness into consideration, too. Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Fixes: 6ae2ff2 ("drm/client: Convert drm_client_buffer_addfb() to drm_mode_addfb2()") Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Javier Martinez Canillas <javierm@redhat.com> Cc: Hamza Mahfooz <hamza.mahfooz@amd.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: <stable@vger.kernel.org> # v6.7+ Link: https://patchwork.freedesktop.org/patch/msgid/20240702121737.522878-1-thuth@redhat.com
1 parent afeea27 commit cb31c58

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/gpu/drm/drm_fbdev_dma.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ static int drm_fbdev_dma_helper_fb_probe(struct drm_fb_helper *fb_helper,
101101
sizes->surface_width, sizes->surface_height,
102102
sizes->surface_bpp);
103103

104-
format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth);
104+
format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp,
105+
sizes->surface_depth);
105106
buffer = drm_client_framebuffer_create(client, sizes->surface_width,
106107
sizes->surface_height, format);
107108
if (IS_ERR(buffer))

0 commit comments

Comments
 (0)