Skip to content

Commit cb56ef8

Browse files
Jonathan-Cavittgregkh
authored andcommitted
drm/xe/xe_guc_ads: save/restore OA registers and allowlist regs
commit 55858fa upstream. Several OA registers and allowlist registers were missing from the save/restore list for GuC and could be lost during an engine reset. Add them to the list. v2: - Fix commit message (Umesh) - Add missing closes (Ashutosh) v3: - Add missing fixes (Ashutosh) Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2249 Fixes: dd08ebf ("drm/xe: Introduce a new DRM driver for Intel GPUs") Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com> Suggested-by: John Harrison <john.c.harrison@intel.com> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> CC: stable@vger.kernel.org # v6.11+ Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20241023200716.82624-1-jonathan.cavitt@intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 2719fe9 commit cb56ef8

1 file changed

Lines changed: 14 additions & 0 deletions

File tree

drivers/gpu/drm/xe/xe_guc_ads.c

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
#include "regs/xe_engine_regs.h"
1414
#include "regs/xe_gt_regs.h"
1515
#include "regs/xe_guc_regs.h"
16+
#include "regs/xe_oa_regs.h"
1617
#include "xe_bo.h"
1718
#include "xe_gt.h"
1819
#include "xe_gt_ccs_mode.h"
@@ -601,6 +602,11 @@ static unsigned int guc_mmio_regset_write(struct xe_guc_ads *ads,
601602
guc_mmio_regset_write_one(ads, regset_map, e->reg, count++);
602603
}
603604

605+
for (i = 0; i < RING_MAX_NONPRIV_SLOTS; i++)
606+
guc_mmio_regset_write_one(ads, regset_map,
607+
RING_FORCE_TO_NONPRIV(hwe->mmio_base, i),
608+
count++);
609+
604610
/* Wa_1607983814 */
605611
if (needs_wa_1607983814(xe) && hwe->class == XE_ENGINE_CLASS_RENDER) {
606612
for (i = 0; i < LNCFCMOCS_REG_COUNT; i++) {
@@ -609,6 +615,14 @@ static unsigned int guc_mmio_regset_write(struct xe_guc_ads *ads,
609615
}
610616
}
611617

618+
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL0, count++);
619+
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL1, count++);
620+
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL2, count++);
621+
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL3, count++);
622+
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL4, count++);
623+
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL5, count++);
624+
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL6, count++);
625+
612626
return count;
613627
}
614628

0 commit comments

Comments
 (0)