Skip to content

Commit cb5eb69

Browse files
mwajdeczgregkh
authored andcommitted
drm/xe/configfs: Don't touch survivability_mode on fini
[ Upstream commit 7934fdc ] This is a user controlled configfs attribute, we should not modify that outside the configfs attr.store() implementation. Fixes: bc417e5 ("drm/xe: Enable configfs support for survivability mode") Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Lucas De Marchi <lucas.demarchi@intel.com> Cc: Riana Tauro <riana.tauro@intel.com> Reviewed-by: Stuart Summers <stuart.summers@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Link: https://lore.kernel.org/r/20250904103521.7130-1-michal.wajdeczko@intel.com (cherry picked from commit 079a5c8) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent c625806 commit cb5eb69

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/gpu/drm/xe/xe_survivability_mode.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040
*
4141
* # echo 1 > /sys/kernel/config/xe/0000:03:00.0/survivability_mode
4242
*
43+
* It is the responsibility of the user to clear the mode once firmware flash is complete.
44+
*
4345
* Refer :ref:`xe_configfs` for more details on how to use configfs
4446
*
4547
* Survivability mode is indicated by the below admin-only readable sysfs which provides additional
@@ -146,7 +148,6 @@ static void xe_survivability_mode_fini(void *arg)
146148
struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
147149
struct device *dev = &pdev->dev;
148150

149-
xe_configfs_clear_survivability_mode(pdev);
150151
sysfs_remove_file(&dev->kobj, &dev_attr_survivability_mode.attr);
151152
}
152153

0 commit comments

Comments
 (0)