net: make page_pool_ref_netmem work with net iovs

isilence · kuba-moo · commit cbc16bceea78 · 2025-01-15T18:44:30.000-08:00
page_pool_ref_netmem() should work with either netmem representation, but currently it casts to a page with netmem_to_page(), which will fail with net iovs. Use netmem_get_pp_ref_count_ref() instead. Fixes: 8ab79ed ("page_pool: devmem support") Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> Signed-off-by: David Wei <dw@davidwei.uk> Link: https://lore.kernel.org/20250108220644.3528845-2-dw@davidwei.uk Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h
@@ -294,7 +294,7 @@ static inline long page_pool_unref_page(struct page *page, long nr)
 
 static inline void page_pool_ref_netmem(netmem_ref netmem)
 {
-	atomic_long_inc(&netmem_to_page(netmem)->pp_ref_count);
+	atomic_long_inc(netmem_get_pp_ref_count_ref(netmem));
 }
 
 static inline void page_pool_ref_page(struct page *page)

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ static inline long page_pool_unref_page(struct page *page, long nr)`
`294`	`294`
`295`	`295`	`static inline void page_pool_ref_netmem(netmem_ref netmem)`
`296`	`296`	`{`
`297`		`- atomic_long_inc(&netmem_to_page(netmem)->pp_ref_count);`
	`297`	`+ atomic_long_inc(netmem_get_pp_ref_count_ref(netmem));`
`298`	`298`	`}`
`299`	`299`
`300`	`300`	`static inline void page_pool_ref_page(struct page *page)`