Skip to content

Commit cc3b18f

Browse files
krzkalexandrebelloni
authored andcommitted
i3c: master: Fix confusing cleanup.h syntax
Initializing automatic __free variables to NULL without need (e.g. branches with different allocations), followed by actual allocation is in contrary to explicit coding rules guiding cleanup.h: "Given that the "__free(...) = NULL" pattern for variables defined at the top of the function poses this potential interdependency problem the recommendation is to always define and assign variables in one statement and not group variable definitions at the top of the function when __free() is used." Code does not have a bug, but is less readable and uses discouraged coding practice, so fix that by moving declaration to the place of assignment. Not that other existing usage of __free() in this context is a corret exception initialized to NULL, because the actual allocation is branched in if(). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Link: https://patch.msgid.link/20251208020750.4727-3-krzysztof.kozlowski@oss.qualcomm.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent 41b80d4 commit cc3b18f

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/i3c/master.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1742,11 +1742,10 @@ EXPORT_SYMBOL_GPL(i3c_master_do_daa);
17421742
struct i3c_dma *i3c_master_dma_map_single(struct device *dev, void *buf,
17431743
size_t len, bool force_bounce, enum dma_data_direction dir)
17441744
{
1745-
struct i3c_dma *dma_xfer __free(kfree) = NULL;
17461745
void *bounce __free(kfree) = NULL;
17471746
void *dma_buf = buf;
17481747

1749-
dma_xfer = kzalloc(sizeof(*dma_xfer), GFP_KERNEL);
1748+
struct i3c_dma *dma_xfer __free(kfree) = kzalloc(sizeof(*dma_xfer), GFP_KERNEL);
17501749
if (!dma_xfer)
17511750
return NULL;
17521751

0 commit comments

Comments
 (0)